search

golang / go

The Go programming language
https://go.dev
BSD 3-Clause "New" or "Revised" License
124.36k stars 17.71k forks source link

x/exp/trace: TestFlightRecorderOneGeneration failures #65207

Closed gopherbot closed 10 months ago

gopherbot commented 10 months ago 
#!watchflakes
default <- pkg == "golang.org/x/exp/trace" && test == "TestFlightRecorderOneGeneration"

Issue created automatically to collect these failures.

Example (log):

==================
WARNING: DATA RACE
Write at 0x00c0000203d0 by goroutine 84:
  runtime.closechan()
      /workdir/go/src/runtime/chan.go:357 +0x0
  runtime.(*wakeableSleep).close()
      /workdir/go/src/runtime/trace2.go:976 +0x54
  golang.org/x/exp/trace.(*FlightRecorder).Stop()
      /workdir/gopath/src/golang.org/x/exp/trace/flightrecorder.go:225 +0x75
  golang.org/x/exp/trace_test.testFlightRecorder()
...
      /workdir/go/src/testing/testing.go:1689 +0x21e
  testing.(*T).Run.gowrap1()
      /workdir/go/src/testing/testing.go:1742 +0x44

Goroutine 92 (running) created at:
  [failed to restore the stack]
==================
--- FAIL: TestFlightRecorderOneGeneration (6.02s)
    --- FAIL: TestFlightRecorderOneGeneration/SetPeriod (3.01s)
        testing.go:1398: race detected during execution of test

— watchflakes

gopherbot commented 10 months ago

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/exp/trace" && test == "TestFlightRecorderOneGeneration"
2024-01-19 08:35 linux-amd64-longtest-race exp@1b970713 go@40fab294 x/exp/trace.TestFlightRecorderOneGeneration (log) ================== WARNING: DATA RACE Write at 0x00c0000203d0 by goroutine 84: runtime.closechan() /workdir/go/src/runtime/chan.go:357 +0x0 runtime.(*wakeableSleep).close() /workdir/go/src/runtime/trace2.go:976 +0x54 golang.org/x/exp/trace.(*FlightRecorder).Stop() /workdir/gopath/src/golang.org/x/exp/trace/flightrecorder.go:225 +0x75 golang.org/x/exp/trace_test.testFlightRecorder() ... /workdir/go/src/testing/testing.go:1689 +0x21e testing.(*T).Run.gowrap1() /workdir/go/src/testing/testing.go:1742 +0x44 Goroutine 92 (running) created at: [failed to restore the stack] ================== --- FAIL: TestFlightRecorderOneGeneration (6.02s) --- FAIL: TestFlightRecorderOneGeneration/SetPeriod (3.01s) testing.go:1398: race detected during execution of test

— watchflakes

gopherbot commented 10 months ago

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/exp/trace" && test == "TestFlightRecorderOneGeneration"
2024-01-19 08:35 linux-amd64-longtest-race exp@1b970713 go@558919b4 x/exp/trace.TestFlightRecorderOneGeneration (log) ================== WARNING: DATA RACE Write at 0x00c000020430 by goroutine 93: runtime.closechan() /workdir/go/src/runtime/chan.go:357 +0x0 runtime.(*wakeableSleep).close() /workdir/go/src/runtime/trace2.go:976 +0x54 golang.org/x/exp/trace.(*FlightRecorder).Stop() /workdir/gopath/src/golang.org/x/exp/trace/flightrecorder.go:225 +0x75 golang.org/x/exp/trace_test.testFlightRecorder() ... /workdir/go/src/testing/testing.go:1689 +0x21e testing.(*T).Run.gowrap1() /workdir/go/src/testing/testing.go:1742 +0x44 Goroutine 90 (running) created at: [failed to restore the stack] ================== --- FAIL: TestFlightRecorderOneGeneration (6.01s) --- FAIL: TestFlightRecorderOneGeneration/SetSize (3.01s) testing.go:1398: race detected during execution of test

— watchflakes

gopherbot commented 10 months ago

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/exp/trace" && test == "TestFlightRecorderOneGeneration"
2024-01-19 08:35 linux-amd64-race exp@1b970713 go@e5eeadb2 x/exp/trace.TestFlightRecorderOneGeneration (log) ================== WARNING: DATA RACE Write at 0x00c000020190 by goroutine 92: runtime.closechan() /workdir/go/src/runtime/chan.go:357 +0x0 runtime.(*wakeableSleep).close() /workdir/go/src/runtime/trace2.go:976 +0x54 golang.org/x/exp/trace.(*FlightRecorder).Stop() /workdir/gopath/src/golang.org/x/exp/trace/flightrecorder.go:225 +0x75 golang.org/x/exp/trace_test.testFlightRecorder() ... /workdir/go/src/testing/testing.go:1689 +0x21e testing.(*T).Run.gowrap1() /workdir/go/src/testing/testing.go:1742 +0x44 Goroutine 90 (running) created at: [failed to restore the stack] ================== --- FAIL: TestFlightRecorderOneGeneration (6.01s) --- FAIL: TestFlightRecorderOneGeneration/SetSize (3.01s) testing.go:1398: race detected during execution of test

— watchflakes

gopherbot commented 10 months ago

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/exp/trace" && test == "TestFlightRecorderOneGeneration"
2024-01-19 08:35 linux-amd64-race exp@1b970713 go@d0dc93c8 x/exp/trace.TestFlightRecorderOneGeneration (log) ================== WARNING: DATA RACE Write at 0x00c0003c41f0 by goroutine 92: runtime.closechan() /workdir/go/src/runtime/chan.go:357 +0x0 runtime.(*wakeableSleep).close() /workdir/go/src/runtime/trace2.go:976 +0x54 golang.org/x/exp/trace.(*FlightRecorder).Stop() /workdir/gopath/src/golang.org/x/exp/trace/flightrecorder.go:225 +0x75 golang.org/x/exp/trace_test.testFlightRecorder() ... /workdir/go/src/testing/testing.go:1689 +0x21e testing.(*T).Run.gowrap1() /workdir/go/src/testing/testing.go:1742 +0x44 Goroutine 90 (running) created at: [failed to restore the stack] ================== --- FAIL: TestFlightRecorderOneGeneration (6.01s) --- FAIL: TestFlightRecorderOneGeneration/SetSize (3.01s) testing.go:1398: race detected during execution of test

— watchflakes

gopherbot commented 10 months ago

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/exp/trace" && test == "TestFlightRecorderOneGeneration"
2024-01-19 08:35 linux-amd64-race exp@1b970713 go@6037c8a8 x/exp/trace.TestFlightRecorderOneGeneration (log) ================== WARNING: DATA RACE Write at 0x00c000020190 by goroutine 84: runtime.closechan() /workdir/go/src/runtime/chan.go:357 +0x0 runtime.(*wakeableSleep).close() /workdir/go/src/runtime/trace2.go:976 +0x54 golang.org/x/exp/trace.(*FlightRecorder).Stop() /workdir/gopath/src/golang.org/x/exp/trace/flightrecorder.go:225 +0x75 golang.org/x/exp/trace_test.testFlightRecorder() ... /workdir/go/src/testing/testing.go:1689 +0x21e testing.(*T).Run.gowrap1() /workdir/go/src/testing/testing.go:1742 +0x44 Goroutine 92 (running) created at: [failed to restore the stack] ================== --- FAIL: TestFlightRecorderOneGeneration (6.01s) --- FAIL: TestFlightRecorderOneGeneration/SetPeriod (3.01s) testing.go:1398: race detected during execution of test

— watchflakes

gopherbot commented 10 months ago

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/exp/trace" && test == "TestFlightRecorderOneGeneration"
2024-01-19 08:35 linux-amd64-longtest-race exp@1b970713 go@93f0c0b2 x/exp/trace.TestFlightRecorderOneGeneration (log) ================== WARNING: DATA RACE Write at 0x00c000110430 by goroutine 93: runtime.closechan() /workdir/go/src/runtime/chan.go:357 +0x0 runtime.(*wakeableSleep).close() /workdir/go/src/runtime/trace2.go:976 +0x54 golang.org/x/exp/trace.(*FlightRecorder).Stop() /workdir/gopath/src/golang.org/x/exp/trace/flightrecorder.go:225 +0x75 golang.org/x/exp/trace_test.testFlightRecorder() ... /workdir/go/src/testing/testing.go:1689 +0x21e testing.(*T).Run.gowrap1() /workdir/go/src/testing/testing.go:1742 +0x44 Goroutine 89 (running) created at: [failed to restore the stack] ================== --- FAIL: TestFlightRecorderOneGeneration (6.01s) --- FAIL: TestFlightRecorderOneGeneration/SetSize (3.01s) testing.go:1398: race detected during execution of test

— watchflakes

gopherbot commented 10 months ago

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/exp/trace" && test == "TestFlightRecorderOneGeneration"
2024-01-19 08:35 linux-amd64-longtest-race exp@1b970713 go@8e02e7b2 x/exp/trace.TestFlightRecorderOneGeneration (log) ================== WARNING: DATA RACE Write at 0x00c000188190 by goroutine 84: runtime.closechan() /workdir/go/src/runtime/chan.go:357 +0x0 runtime.(*wakeableSleep).close() /workdir/go/src/runtime/trace2.go:976 +0x54 golang.org/x/exp/trace.(*FlightRecorder).Stop() /workdir/gopath/src/golang.org/x/exp/trace/flightrecorder.go:225 +0x75 golang.org/x/exp/trace_test.testFlightRecorder() ... /workdir/go/src/testing/testing.go:1689 +0x21e testing.(*T).Run.gowrap1() /workdir/go/src/testing/testing.go:1742 +0x44 Goroutine 92 (running) created at: [failed to restore the stack] ================== --- FAIL: TestFlightRecorderOneGeneration (6.02s) --- FAIL: TestFlightRecorderOneGeneration/SetPeriod (3.01s) testing.go:1398: race detected during execution of test

— watchflakes

gopherbot commented 10 months ago

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/exp/trace" && test == "TestFlightRecorderOneGeneration"
2024-01-19 08:35 linux-amd64-longtest-race exp@1b970713 go@b91bad78 x/exp/trace.TestFlightRecorderOneGeneration (log) ================== WARNING: DATA RACE Write at 0x00c000118370 by goroutine 92: runtime.closechan() /workdir/go/src/runtime/chan.go:357 +0x0 runtime.(*wakeableSleep).close() /workdir/go/src/runtime/trace2.go:976 +0x54 golang.org/x/exp/trace.(*FlightRecorder).Stop() /workdir/gopath/src/golang.org/x/exp/trace/flightrecorder.go:225 +0x75 golang.org/x/exp/trace_test.testFlightRecorder() ... /workdir/go/src/testing/testing.go:1689 +0x21e testing.(*T).Run.gowrap1() /workdir/go/src/testing/testing.go:1742 +0x44 Goroutine 91 (running) created at: [failed to restore the stack] ================== --- FAIL: TestFlightRecorderOneGeneration (6.02s) --- FAIL: TestFlightRecorderOneGeneration/SetSize (3.01s) testing.go:1398: race detected during execution of test

— watchflakes

gopherbot commented 10 months ago

Change https://go.dev/cl/560215 mentions this issue: runtime: model wakeableSleep.lock in the race detector

gopherbot commented 10 months ago

Change https://go.dev/cl/559956 mentions this issue: [release-branch.go1.22] runtime: model wakeableSleep.lock in the race detector