search

goldbergyoni / nodebestpractices

:white_check_mark: The Node.js best practices list (July 2024)
https://twitter.com/nodepractices/
Creative Commons Attribution Share Alike 4.0 International
99.44k stars 10.12k forks source link

*Vote here: how should our example solution look like? #204

Closed goldbergyoni closed 5 years ago

goldbergyoni commented 6 years ago

We want to start demonstrating all the best practices in a code solution. Should it be a minimal boilerplate/starter for new projects or rich example application?

Help us decide here:

https://twitter.com/nodepractices/status/1014851478580875265

@refack @idori @js-kyle @BrunoScheufler @lirantal @benjamingr @kevinrambaud @t1st3 @kudapara @kalitas @matheusrocha89 @ChangJoo-Park @mfine15 @squgeim

MarkAdell commented 6 years ago

What is the state of this?

goldbergyoni commented 6 years ago

@MarkAdell Still considering whether this is the right activity to spend on so many nights during the next year? :]

What do you think? would you use it as a starter or for learning? any other thoughts/recommendations will be great

MarkAdell commented 6 years ago

@i0natan I would use it for learning about the best practices and applying it to existing and new projects.

I built my own boilerplate but I'm sure it's lacking a lot of things. It's a combination of other popular boilerplates + my own customizations based on some of the best practices presented in this repo.

goldbergyoni commented 6 years ago

@MarkAdell Curious to hear, which are your favorites boilerplates?

p.s. had a look at your starter, looks very nice. Consider not putting DB logic in an "api" as they server different purposes and layers

MarkAdell commented 6 years ago

@i0natan Thank you!

What do you think of putting the dataAccess files under a folder named "DAL" inside src/db folder?

these are some of my favorite boilerplates : https://github.com/cham11ng/typescript-api-starter https://github.com/danielfsousa/express-rest-es2017-boilerplate https://github.com/EQuimper/nodejs-api-boilerplate

goldbergyoni commented 6 years ago

What do you think of putting the dataAccess files under a folder named "DAL" inside src/db folder?

Yes. Or a DAL class under the db folder (along with migration files)

@MarkAdell Ping if you'd like to join any of the activities that are desctribed above

stale[bot] commented 5 years ago

Hello there! 👋 This issue has gone silent. Eerily silent. ⏳ We currently close issues after 100 days of inactivity. It has been 90 days since the last update here. If needed, you can keep it open by replying here. Thanks for being a part of the Node.js Best Practices community! 💚