search

goniszewski / grimoire

Bookmark manager for the wizards 🧙
https://grimoire.pro
MIT License
1.99k stars 58 forks source link

Adding/loading bookmarks doesn't work correctly with custom domain #22

Closed goniszewski closed 5 months ago

goniszewski commented 10 months ago 
          > With commit [d485055](https://github.com/goniszewski/grimoire/commit/d485055081a5d191a6782a3363e13c8dce8cc97b) I was successful in launching the app via `docker compose up` for external IP, domain as well as simply local deployment. Moreover, this commit fixes an issue with invalid URLs for files stored by PocketBase.

I hope it will work for you guys just fine this time. Please inform me if that's the case, or if there are any issues or questions related to new/updated environment variables. And also, please accept my apologies for this mess!

It worked for me, but there are still a few issues I observe.

  1. After creating a user, I get a 500 error one single time with the same TypeError: Cannot read properties of null (reading 'id') error. But after refreshing I'm logged in.

  2. Adding a new bookmark just freezes after the spinning circle to grab the meta data. I can, however, press enter again at the URL box to save it.

  3. Saving the bookmark does not add the bookmark to the bookmarks page automatically. I had to manually refresh again to see it appear.

  4. The new bookmark has no meta data, only the URL and HTML code is saved. Images, titles etc are not saved, this is presumably due to error number 2.

Originally posted by @maya329 in https://github.com/goniszewski/grimoire/issues/12#issuecomment-1830138881

goniszewski commented 9 months ago

First problem is now resolved, but the rest probably not.

I have also seen an issue where some URL, even after successfully loading its metadata, couldn't be saved. It may be related somehow (need further investigation).

goniszewski commented 5 months ago

With the latest changes, related issues should be resolved. If that's not the case, new, more detailed issues should be created.