google-code-export / ffmpegthumbnailer

Automatically exported from code.google.com/p/ffmpegthumbnailer
GNU General Public License v2.0
1 stars 1 forks source link

Cant thumbnail a file with non-Ascii characters in filename #43

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. try to call VideoThumbnailer::generateThumbnail(videoFile); with 
videoFile containing non-Ascii characters.

What is the expected output? What do you see instead?
Thumbnail generated. Instead there is no output.

What version of the product are you using? On what operating system?
ffmpegthumbnailer-1.5.5
Gentoo Linux

Please provide any additional information below.

Original issue reported on code.google.com by vovan...@gmail.com on 31 Oct 2009 at 8:27

GoogleCodeExporter commented 9 years ago
I can't reproduce this. Is your locale set properly?

Original comment by dirk.vdb on 2 Nov 2009 at 8:24

GoogleCodeExporter commented 9 years ago
My locale is ru_RU.UTF-8.

Original comment by vovan...@gmail.com on 4 Nov 2009 at 10:57

GoogleCodeExporter commented 9 years ago
Can you try to run the unittests and see if they pass?

You will need to install the gtest library
(http://gentoo-overlays.zugaina.org/dev-zero/dev-util.html.en#gtest)

Then:

./configure --enable-unittests
make check

Original comment by dirk.vdb on 4 Nov 2009 at 11:08

GoogleCodeExporter commented 9 years ago
Done:
[==========] Running 5 tests from 2 test cases.
[----------] Global test environment set-up.
[----------] 3 tests from VideoThumbnailerTest
[ RUN      ] VideoThumbnailerTest.CreateHistogramBlackFrame
[       OK ] VideoThumbnailerTest.CreateHistogramBlackFrame (0 ms)
[ RUN      ] VideoThumbnailerTest.CreateHistogramWhiteFrame
[       OK ] VideoThumbnailerTest.CreateHistogramWhiteFrame (0 ms)
[ RUN      ] VideoThumbnailerTest.FrameSelection
[       OK ] VideoThumbnailerTest.FrameSelection (0 ms)
[----------] 3 tests from VideoThumbnailerTest (0 ms total)

[----------] 2 tests from HistogramTest
[ RUN      ] HistogramTest.CreationInt
[       OK ] HistogramTest.CreationInt (0 ms)
[ RUN      ] HistogramTest.CreationFloat
[       OK ] HistogramTest.CreationFloat (0 ms)
[----------] 2 tests from HistogramTest (0 ms total)

[----------] Global test environment tear-down
[==========] 5 tests from 2 test cases ran. (1 ms total)
[  PASSED  ] 5 tests.

Original comment by vovan...@gmail.com on 4 Nov 2009 at 11:16

GoogleCodeExporter commented 9 years ago
I am sorry - my fault, everything is fine, the problem is in 
kde4-ffmpegthumbnailer...

Calling ffmpegthumbnailer from commandline works OK.

Original comment by vovan...@gmail.com on 4 Nov 2009 at 11:19

GoogleCodeExporter commented 9 years ago
Oh, I forgot to mention you have to use the version in svn.

Original comment by dirk.vdb on 4 Nov 2009 at 11:19

GoogleCodeExporter commented 9 years ago
Maybe you need to call

setlocale(LC_CTYPE, "")

in your main

Original comment by dirk.vdb on 4 Nov 2009 at 11:27

GoogleCodeExporter commented 9 years ago
The problem was in using QString->toAscii() instead of QString->toLocal8bit().

Thanks!

Original comment by vovan...@gmail.com on 4 Nov 2009 at 11:33

GoogleCodeExporter commented 9 years ago
OK, Marking as invalid then.

Original comment by dirk.vdb on 4 Nov 2009 at 11:57