search

google-code-export / flowplayer-core

Automatically exported from code.google.com/p/flowplayer-core
2 stars 0 forks source link

ViralVideo plugin breaks config by URL feature #335

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
I noticed you can't use an external configuration passed via URL because 
ViralVideo plugin modifies the configuration for the sharing feature and as a 
result overwrite the URL by the configuration. It needs to duplicate the 
configuration instead of modifying it.

Original issue reported on code.google.com by jns.fe...@gmail.com on 7 Jul 2011 at 6:22

GoogleCodeExporter commented 9 years ago 
I started working on this

Original comment by jns.fe...@gmail.com on 8 Jul 2011 at 1:44

GoogleCodeExporter commented 9 years ago 
Please be careful to not change the sharing functionality as it is now - it 
finally works, see issue265

Original comment by blacktrashproduct on 8 Jul 2011 at 4:01

GoogleCodeExporter commented 9 years ago 
thanks for telling me christian, I've actually noticed there has been a lot of 
changes lately on this plugin and I'm not sure if this issue if still valid. I 
haven't really tested but I might ask anssi / electroteque.

Original comment by jns.fe...@gmail.com on 12 Jul 2011 at 3:18

GoogleCodeExporter commented 9 years ago 
issue has been fixed with the last modifications anyway : )

Original comment by jns.fe...@gmail.com on 21 Jul 2011 at 4:43