google-code-export / marinemap

Automatically exported from code.google.com/p/marinemap
Other
1 stars 2 forks source link

move northcoast-specific unit and srid assumptions out of lingcod #411

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
There are a number of cases where northcoast assumptions, data, code, etc are 
tied into the main lingcod app. 

1. data migrations - (0003 in spacing) load up data with a hardcoded srid
2. other fixtures with nc data
3. unit assumptions in much of the codebase
4. hardcoded srid, units, etc

We should spend time doing a thorough code review and coming up with a plan. Or 
maybe it just needs to be dealt with incrementally, just dealing with each 
individual issue when we notice them? 

Original issue reported on code.google.com by perrygeo...@gmail.com on 24 Jun 2010 at 1:13

GoogleCodeExporter commented 9 years ago

Original comment by perrygeo...@gmail.com on 24 Jun 2010 at 1:31

GoogleCodeExporter commented 9 years ago
Also, check the media folder for anything northcoast-specific like the 
mpa-*.png icons

Original comment by perrygeo...@gmail.com on 24 Jun 2010 at 9:10

GoogleCodeExporter commented 9 years ago
Here's the list of files in the lingcod package with hardcoded 3310 somewhere:

./bioeconomic_model/models.py:  
./bioregions/migrations/0001_initial.py:   
./depth_range/migrations/0001_initial.py:     
./intersection/migrations/0002_auto__chg_field_intersectionfeature_multi_shapefi
le.py
./intersection/models.py:
./intersection/views.py:
./pg_spacing/models.py:
./pg_spacing/views.py:
./screencasts/migrations/0003_populate_youtube_screencasts.py:
./spacing/migrations/0001_initial.py: 
./spacing/models.py:
./spacing/views.py: 
./straightline_spacing/migrations/0001_initial.py:

Original comment by perrygeo...@gmail.com on 5 Aug 2010 at 5:50

GoogleCodeExporter commented 9 years ago
So changeset 9a10297ad819 should have removed all of the hardcoded 3310 srid 
assumptions and Jared's work with the unit_conversion app should handle all the 
unit calculation issues. Lets call this one closed for now, dealing with any 
similar bugs on an as-needed basis.  

Original comment by perrygeo...@gmail.com on 5 Aug 2010 at 7:06