Closed GoogleCodeExporter closed 9 years ago
On further reflection I changed my request ;)
I don't think we should change the preset - rather leave it as 'use logos of
currently selected skin' as that preserves backwards compatibility.
The ONLY case where we may wish to change to MyFilms logos pack is for Default
skin - if so then we should install MyFilmsLogos.xml to Default skin folder,
rather than have every skin add it if they wish to use skin logos.
Original comment by Dade...@gmail.com
on 1 Aug 2013 at 2:47
Original comment by Guzz...@googlemail.com
on 7 Aug 2013 at 10:04
This issue was closed by revision r2895.
Original comment by Guzz...@googlemail.com
on 8 Aug 2013 at 2:30
I can verify that the skin logo files are removed from SVN and installer
(though MyFilms-12.xmp2 still contains references in the skin files section to
Blue3/wide logos (e.g. %Skin%\Blue3\Media\Logos\MyFilms\Family.png) which could
be removed now.
However, the main problem is the installer does NOT remove the previous
Default/Wide \Media\Logos\MyFilms folder, so if you had installed MyFilms
previously, the logos still exist :(. Thus I have reopened this issue since
installer should also delete any previous folders if they exist i.e.:
Default\Media\Logos\MyFilms
Defaultwide\Media\Logos\MyFilms
Logos Setup wiki page has been updated - removing references to MP Logos Pack
Original comment by Dade...@gmail.com
on 28 Aug 2013 at 4:11
OK I am a bit confused now. Although I don't see the
Default[wide]\Media\Logos\MyFilms in the installer, if I delete the folders
manually, they are actually reinstalled using build 2908!
Original comment by Dade...@gmail.com
on 30 Aug 2013 at 3:56
This issue was closed by revision r2920.
Original comment by Guzz...@googlemail.com
on 31 Aug 2013 at 1:49
This issue was closed by revision r2921.
Original comment by Guzz...@googlemail.com
on 1 Sep 2013 at 12:29
verified that r2921 removes the Default skin media\logos\MyFilms folders on
install.
Original comment by Dade...@gmail.com
on 1 Sep 2013 at 1:17
Original issue reported on code.google.com by
Dade...@gmail.com
on 29 Jul 2013 at 6:03