Closed GoogleCodeExporter closed 9 years ago
Sorry, this came up as "defect" - I didn't see how to set it to "enhancement" -
sorry!
Original comment by brother....@gmail.com
on 15 Sep 2011 at 4:02
From the project page:
"If you find any bugs or have any suggestions for the implemented lexers (and
not only) feel free to provide patches. Without any patches, you shouldn't
bother making a new request as it probably won't happen."
Original comment by XhmikosR
on 15 Sep 2011 at 5:51
This is a request for a button, not a lexer. Aren't buttons a GUI thing?
Original comment by brother....@gmail.com
on 15 Sep 2011 at 8:02
[deleted comment]
Never said they aren't. Still no patch, no joy. Sorry.
Original comment by XhmikosR
on 15 Sep 2011 at 8:13
I know a bit about programming, but I don't know how to make a patch. Is there
somewhere else I can request for someone to add the feature? I use
notepad2-mod because it has the lexers I want.
Original comment by brother....@gmail.com
on 16 Sep 2011 at 1:42
Well my main problem is the toolbar images. Otherwise it should be pretty
straight forward to add such an image code wise.
Have a look at the "res" directory in the svn and try to add a new image in the
toolbar images in there. After that I might have a look.
Original comment by XhmikosR
on 16 Sep 2011 at 1:50
Okay, I added a "run" icon to the tail of toolbar.bmp. In the res folder, I
saw two other toolbar bmps, but they didn't look like the one being used. I
have attached the file here. I called mine, "Toolbar3.bmp". If you want to
make any other additions or edits, just let me know; it's pretty simple.
Original comment by brother....@gmail.com
on 16 Sep 2011 at 2:41
Attachments:
Something is off with your image. Compare it to the original Toolbar.bmp and
you'll see what I mean. Toobar.bmp is the one currently used by default but if
I'm going to add it I need the other 2 toolbar images updated too.
Original comment by XhmikosR
on 16 Sep 2011 at 2:49
I took a good look, but I can't see anything weird. It is longer, however.
Both images are 32 bit with alpha blend. I'll add the other two toolbars in a
moment...
Original comment by brother....@gmail.com
on 16 Sep 2011 at 3:00
They are not the same. Of course they will be longer but your attached bitmap
is messed up. Try having a closer look.
Original comment by XhmikosR
on 16 Sep 2011 at 3:05
Attachments:
Okay, apparently, the editor I was using did not edit the alpha channel, so I
did it in photoshop. Sorry for the hassle; try this one:
Original comment by brother....@gmail.com
on 16 Sep 2011 at 3:24
Attachments:
I'm sorry I don't have time for this. Your images are messed up and are not
like the original one. Plus you replace the last image with the new one which
is wrong.
Original comment by XhmikosR
on 16 Sep 2011 at 3:33
Please forgive me! I am trying! After I realized about the alpha channel, I
think I have it right now. I didn't change that other image - that was the
original bmp in the res folder. I have ONLY added the last image. It is true
- in "toolbar.bmp", that one button in the middle is NOT the same as the
buttons in the other toolbars - I didn't do that. That is how the originals
are in the res folder (and I can't change anything there). I have all three
toolbar bmps here, and I think they are right. If you look in res, there are
three bmps. My new ones are exactly the same as those except for the last
image. Please look one more time!
Original comment by brother....@gmail.com
on 16 Sep 2011 at 3:51
Attachments:
These images have the same problems. I cannot use them.
Try attaching the 16x16 launch image only.
PS. It might take a while before I add it.
Original comment by XhmikosR
on 17 Sep 2011 at 8:02
Okay, here is the 16x16 launch icon. Please accept my apology for not getting
the toolbar right; I am not sure what is wrong, so I don't know how to fix it.
I am, however, interested in doing it right, and would volunteer to do this for
y'all's project whenever you like, that is, supposing I could do it for you the
right way. I would like to help, as I use Notepad2-mod as one of my primary
apps. Just send me an email and I'll do what I can. Oh, and I attached the
icon here. Thanks for not giving up on me!
Original comment by brother....@gmail.com
on 17 Sep 2011 at 2:28
Attachments:
I'm not sure it's completely legal to use that icon.
Nevertheless, here is a test build.
Original comment by XhmikosR
on 17 Sep 2011 at 7:23
Attachments:
Hey, that's absolutely wonderful! I'm not sure if it's completely legal
either; I have seen other programs use that icon, however. Would you like if I
came up with something different? Thank you very much for the demo. I like it
alot and will use it alot. It is very handy for testing powerpro scripts or
autohotkey scripts.
Original comment by brother....@gmail.com
on 17 Sep 2011 at 7:57
I'd prefer if I could use another icon which will look clean at 16x16. Until
then, I'm not going to commit the changes though.
Original comment by XhmikosR
on 17 Sep 2011 at 8:06
Tango icons are somewhat like the icons in np2. What about the orange disc
with an exclamation mark? Third row, third icon. There are the footprints in
the seventh row, toward the center - could be a symbol for "run", although I'm
not too partial to that. But I like the bottom row, 6th icon - looks like a
command box.
http://tango.freedesktop.org/Tango_Icon_Library
Or, you can try this lightning bolt icon, or this other cmd box icon which I
got from Proxal Icon Set 2.0. They say, "Feel free to use this icon set any
way you wish, just not commercially. Using the icons on your website, or custom
mods, or even applications is fine by me. I just ask that you be so kind as to
place a credit to me somewhere in your works. On websites a comment tag will
suffice. You do not need to get prior permission from me in order to use them."
Their site is:
http://www.miranda-im.org/
If I get a better idea, I'll post back. Thanks for the "accepted" status!
Original comment by brother....@gmail.com
on 17 Sep 2011 at 8:45
Attachments:
I think I'll go with the attached solution. The image is taken from here:
http://www.famfamfam.com/lab/icons/silk/
Original comment by XhmikosR
on 19 Sep 2011 at 8:24
Attachments:
Mr. XhmikosR, that looks fantastic. You get my vote. I think the silk icons
look like a good match for np2. Thanks, again.
Original comment by brother....@gmail.com
on 19 Sep 2011 at 1:45
Committed in r572.
Original comment by XhmikosR
on 19 Sep 2011 at 6:24
Original issue reported on code.google.com by
brother....@gmail.com
on 15 Sep 2011 at 4:01