search

google-code-export / wagic

Automatically exported from code.google.com/p/wagic
1 stars 0 forks source link

[Internal] "AI Hints" should be moved outside of primitives database #498

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
the following change introduces "hints" for the AI to use level up creatures:
http://code.google.com/p/wagic/source/detail?r=2487

although this is ok as a temporary measure, this has several drawbacks:

1. The major issue is that the primitives files should NOT contain anything 
else than the cards Database. This is a core concept of the MVC pattern, we 
don't want to put any "control" information in the "data" part

2. A second issue is that the AI should be able to guess these values by 
getting information directly for the parsed Abilities. I'd rather have a 
somewhat complex code in the AI to get this information, than "hints" that need 
to be manually entered. This is not good for scalability, and we don't want 
card coders to be involved with what the AI does.

3. A third issue is that adding variables in the MTGPrimitive or the MTGCard 
headers adds a high Ram consumption. Adding a single int value to these 
increases the size of the DB in Ram by 12 kB since we have 12000 cards.

If we really need "AI hints" they should be moved to a separate file and a 
separate class.
But I think that we don't need these hints, instead, we can probably come up 
with a dirty yet efficient way of doing this directly in the code.

Original issue reported on code.google.com by wagic.the.homebrew@gmail.com on 30 Oct 2010 at 4:00

GoogleCodeExporter commented 9 years ago 
not sure i follow too well why this is an issue.

all it does is set a varible, exactly like kicker, manacost, power, 
toughness...that can be checked later on by functions.

Original comment by omegabla...@gmail.com on 31 Oct 2010 at 4:17

GoogleCodeExporter commented 9 years ago 
the main function was also moved from MTGCard, to MTGPrimitive in this rev.

http://code.google.com/p/wagic/source/detail?r=2491

Original comment by omegabla...@gmail.com on 31 Oct 2010 at 4:48

GoogleCodeExporter commented 9 years ago 
also, you consider this a "high" issue...but multiple mays on Ai stack crashing 
wagic, a strange debug assertion error, and "random crashes from winning a 
match" are not?

Original comment by omegabla...@gmail.com on 31 Oct 2010 at 4:49

GoogleCodeExporter commented 9 years ago

Original comment by omegabla...@gmail.com on 31 Oct 2010 at 5:20