build fails against libnotify-0.7.1

[GoogleCodeExporter]

compiling xnoise (current hg checkout) against libnotify-0.7:
xnoise-notifications.c: In function 'xnoise_notifications_show_notification':
xnoise-notifications.c:442:3: error: too many arguments to function 
'notify_notification_new'

Original issue reported on code.google.com by mende.christoph on 28 Apr 2011 at 7:44

[GoogleCodeExporter]

the problem seems to be line 162 in 
plugins/notifications/xnoise-notifications.vala:
                        notification = new Notification(summary, body, null, null);
4 parameters are expected in libnotify <0.7, >=0.7 wants three (just drop the 
last one).
I have no idea about vala though, but in C you'd check for NOTIFY_CHECK_VERSION.

Original comment by mende.christoph on 28 Apr 2011 at 9:19

[GoogleCodeExporter]

There was an API break in libnotify with version 0.7. The vapi shipped with the 
current vala is for libnotify-0.7 but that version is not yet available on many 
systems (on ubuntu natty there are both versions 0.5 and 0.7). For that reason, 
I put a old libnotify 0.5 vapi (in the vapi subdirectory) into the xnoise tree 
which is used instead of the new 0.7 version.

I could try to make a conditional build depending on the libnotify version 
because I don't want to fully drop support for older systems by now. 
Are you willing to test?

Original comment by shuerhaaken on 29 Apr 2011 at 7:15

[GoogleCodeExporter]

Original comment by shuerhaaken on 29 Apr 2011 at 7:15

[GoogleCodeExporter]

Sure, just tell me whatever you need tested.

Original comment by mende.christoph on 29 Apr 2011 at 7:17

[GoogleCodeExporter]

This might actually be fixable in a different way, if you could provide a 
configure option to use the system vapis. Or would it require code changes too 
when using the Notify-0.7 vapi?

Original comment by mende.christoph on 29 Apr 2011 at 8:28

[GoogleCodeExporter]

That is what I meant with 'conditional build' - only that there should be an 
automatic check of the version. And yes, it requires code changes, too.

Not sure if this works well for released tarballs.
I will take care of this asap.

Original comment by shuerhaaken on 30 Apr 2011 at 6:25

• Changed state: Accepted

[GoogleCodeExporter]

Compiling xnoise (current hg checkout) against libnotify-0.7 should now work.
Don't forget to do ./autogen.sh after getting new hg version.
There is a version switch now. 

Original comment by shuerhaaken on 1 May 2011 at 2:32

• Changed state: Fixed

[GoogleCodeExporter]

Fixed indeed, thanks

Original comment by mende.christoph on 1 May 2011 at 5:51