configure checks valac even if it's not required

[GoogleCodeExporter]

The xnoise tarballs don't need valac to build (afaict), but the configure 
script still bails out if /usr/bin/valac exists, but is too old. Not quite sure 
how this could be fixed in an easy way, but the configure script should prolly 
not check for valac at all in the tarballs.

Original issue reported on code.google.com by ange...@unkreativ.org on 16 May 2011 at 11:32

[GoogleCodeExporter]

Please read here:
http://code.google.com/p/xnoise/wiki/BUILD  : 

"...Please note that due to an automake issue you have to have at least 
vala-0-11.5 OR no vala at all to compile xnoise from a released source package. 
Compiling the source while having an old version of vala on your computer will 
not work ..."

I filed bugs on this and reported this on the autotools mailing list. Didn't 
get any reaction.
So workaround for this is to remove vala from the computer. 

Original comment by shuerhaaken on 16 May 2011 at 12:09

• Changed state: WontFix

[GoogleCodeExporter]

Well yes, but I can't see any difference between the xnoise built with no vala 
and one built with vala-0.12. So what I'm asking for is prolly an option to 
disable the vala check completely. Maybe put it in an AC_ARG_ENABLE?

Original comment by ange...@unkreativ.org on 16 May 2011 at 12:28

[GoogleCodeExporter]

There is no difference in the build sources because I build the sources with 
vala-0.12. 

But vala shouldn't be used at all for released tarballs! That's the bug in 
autotools I was talking about. Only build sources should be used.

I don't have much time but I'll check if this could be worked around with an 
AC_ARG_ENABLE option. Let's see if this goes together with AM_PROG_VALAC. 

If you need a fast result and you have some time, I will happily include a 
patch for this ;)

regards

Original comment by shuerhaaken on 16 May 2011 at 1:59

• Changed state: Accepted
• Added labels: Type-Enhancement, Priority-Low
• Removed labels: Type-Defect, Priority-Medium

[GoogleCodeExporter]

Hello
I attached a slightly modified version of xnoise to this issue report.
It has some modified autotools stuff.
Can you test if it is working as expected? 

Original comment by shuerhaaken on 17 May 2011 at 9:24

Attachments:

• xnoise-0.1.22.tar.bz2

[GoogleCodeExporter]

It does work as expected. Even though I was more thinking of something like 
AM_MAINTAINER_MODE. Didn't find a way to check for that in configure.ac though.
Anyway, this is fine too, thanks.

PS: would've been fine if you just attached a diff, I'm more used to that ;)

Original comment by ange...@unkreativ.org on 17 May 2011 at 9:31

[GoogleCodeExporter]

Ok. What do you expect to be better with AM_MAINTAINER_MODE?
I would not want to make the developer use --enable-maintainer-mode everytime 
they do configure or autogen.

I don't use diffs in this context very often, so I just uploded the package 
because of lazyness. Maybe a diff next time ;) 

Original comment by shuerhaaken on 17 May 2011 at 9:57

[GoogleCodeExporter]

Well, I don't expect it to be better, it's just that maintainer mode is 
supposed to be used to generate source. Xfce autogen scripts for example always 
pass --enable-maintainer-mode to configure.
The only case where the current implementation fails is when developers (i.e. 
those where vala is required to build) have an old vala version, but since 
users won't care about that (and the case is prolly rare enough), this is 
perfectly fine imho.

Original comment by ange...@unkreativ.org on 17 May 2011 at 10:31

[GoogleCodeExporter]

Oh, and I just noticed xnoise uses gnome-autogen which also passes  
--enable-maintainer-mode by default ;)

Original comment by ange...@unkreativ.org on 17 May 2011 at 11:03

[GoogleCodeExporter]

hmm. I'll look into that asap. I have to find out more about 
AM_MAINTAINER_MODE, first.
Eventually I will add a change to use AM_MAINTAINER_MODE. 

Thanks for pointing this out!

Original comment by shuerhaaken on 17 May 2011 at 12:07

[GoogleCodeExporter]

Original comment by shuerhaaken on 21 May 2011 at 12:34

• Changed state: Fixed