Erroneous Flag in Suggested Code

google-deepmind / dqn_zoo

DQN Zoo is a collection of reference implementations of reinforcement learning agents developed at DeepMind based on the Deep Q-Network (DQN) agent.

Apache License 2.0

451 stars 78 forks source link

Erroneous Flag in Suggested Code #5

Closed RylanSchaeffer closed 3 years ago

RylanSchaeffer commented 4 years ago

The psuedocode


      python -m "dqn_zoo.${agent}.run_atari" \
          --environment_name="${game}" \
          --seed="${seed}" \
          --results="/tmp/dqn_zoo/${agent}/${game}/${seed}/results.csv"

uses a flag results which doesn't exist. I think results_csv_path was meant.

jqdm commented 3 years ago

Thanks, fixed by f6ea040cb5e55bf65da6cfa07d4daf8225245fa9.