search

google-deepmind / open_spiel

OpenSpiel is a collection of environments and algorithms for research in general reinforcement learning and search/planning in games.
Apache License 2.0
4.26k stars 934 forks source link

Google Colab build issue #170

Closed oslumbers closed 4 years ago

oslumbers commented 4 years ago

Hi, I'm having an issue building the open spiel environment this morning that wasn't an issue yesterday, happens at 63% of build. Here's the error: Makefile :94: recipe for target 'all' failed make: *** [all] Error 2 Happy to give more info if needed

sullins2 commented 4 years ago

I have the same issue as well.

lanctot commented 4 years ago

Hmm.. last time we did an update was Monday so might be that the systems running the colabs changed configurations.

I will look into it, thanks.

lanctot commented 4 years ago

Noticed a few other things that need attention in the colab:

  1. This line !pip3 install --upgrade mock==3.0.5 also fails.
  2. It's still using g++, which we switched away from a while back (we're using clang++ now).
lanctot commented 4 years ago

I've reproduced the error on our side (even internally, on my workstation), which is odd. Wasn't happening on Monday either. Must be due to a global change in compiler / linker on Google systems. Looks like it should be an easy problem to fix, and we'll do an update as soon as it's fixed.

sullins2 commented 4 years ago

Thanks

lanctot commented 4 years ago

I just noticed we're not fixing the version or commit of absl; it's possibly due to a new change in absl. I'll try with an older commit.

lanctot commented 4 years ago

I just noticed we're not fixing the version or commit of absl; it's possibly due to a new change in absl. I'll try with an older commit.

Confirming it's due to a recent change in abseil. Fix coming soon.

lanctot commented 4 years ago

Should work now, but you might have to clear your old build directory by adding

% rm -rf open_spiel

after the % cd /usr/local.

sullins2 commented 4 years ago

Working again. Thanks @lanctot