google-github-actions / auth

A GitHub Action for authenticating to Google Cloud.
https://cloud.google.com/iam
Apache License 2.0
968 stars 207 forks source link

Note .dockerignore in the exclusion for credentials #375

Closed andrewhowdencom closed 11 months ago

andrewhowdencom commented 11 months ago

The README indicates that the ghe-* files should be excluded from git via the .gitignore file. However, from CI, it is less likely that users will create a new patch back to their version control with the results of their build, but it is more likely that they'll pack it into a container.

This commit clarifies that the container is an equal (or larger) risk and should be excluded. This also works (for example) with Podman.

See:

  1. https://docs.docker.com/engine/reference/builder/