PR proposal : Wrong var name and route in sample

cesar-richard commented 3 years ago

The code just cloned isn't able to run without these two fixes.

From c3277d1406e247aa4f24f52ca8c41a10588cbfb7 Mon Sep 17 00:00:00 2001
From: Cesar Richard <cesar.richard@weezevent.com>
Date: Fri, 18 Dec 2020 11:22:46 +0100
Subject: [PATCH] Fixed route and var names in fulfillment

---
 README.md            | 2 +-
 src/auth-provider.ts | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/README.md b/README.md
index b258740..160bd80 100644
--- a/README.md
+++ b/README.md
@@ -85,7 +85,7 @@ npm run deploy

 1. Navigate back to the [Actions on Google Console](https://console.actions.google.com).
 1. From the top menu under *Develop*, click on *Actions* (left nav). Click on *Add your first action* and choose your app's language(s).
-1. Enter the URL for fulfillment: [`PROJECT_ID`](https://firebase.google.com/docs/projects/learn-more#project-id)`.web.app/fulfillment`. and click *Done*.
+1. Enter the URL for fulfillment: [`PROJECT_ID`](https://firebase.google.com/docs/projects/learn-more#project-id)`.web.app/smarthome`. and click *Done*.
 1. On the left navigation menu under *ADVANCED OPTIONS*, click on *Account Linking*.
     1. Select *No, I only want to allow account creation on my website*. Click *Next*.
     1. For Linking Type, select *OAuth*.
diff --git a/src/auth-provider.ts b/src/auth-provider.ts
index 6c5aa0d..c34f4d5 100644
--- a/src/auth-provider.ts
+++ b/src/auth-provider.ts
@@ -46,7 +46,7 @@ app.get('/login', (req, res) => {
   res.send(`<html>
 <body>
 <form action="/login" method="post">
-<input type="hidden" name="responseurl" value="${req.query.responseurl}" />
+<input type="hidden" name="response_url" value="${req.query.response_url}" />
 <button type="submit" style="font-size:14pt">Link this service to Google</button>
 </form>
 </body>
-- 
2.23.0

proppy commented 3 years ago

Fixed thanks!

proppy commented 3 years ago

Actually the change for the fulfillment still need to be pushed.

google-home / smart-home-nodejs

PR proposal : Wrong var name and route in sample #527