google / TensorNetwork

A library for easy and efficient manipulation of tensor networks.
Apache License 2.0
1.82k stars 359 forks source link

fixed missing edge in create_MPS #838

Closed dncolomer closed 4 years ago

dncolomer commented 4 years ago

The first edge created for the case where rank = 2 was not being appended to the connected_edges array

google-cla[bot] commented 4 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

dncolomer commented 4 years ago

@googlebot I signed it!

codecov-commenter commented 4 years ago

Codecov Report

Merging #838 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #838   +/-   ##
=======================================
  Coverage   98.37%   98.37%           
=======================================
  Files         129      129           
  Lines       22103    22103           
=======================================
  Hits        21743    21743           
  Misses        360      360           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 44bbdb4...8a3d049. Read the comment docs.