search

google / binexport

Export disassemblies into Protocol Buffers
Apache License 2.0
1.05k stars 206 forks source link

Fix linking errors for MSVC #142

Closed chitoge closed 1 month ago

chitoge commented 1 month ago

This PR fixes recent GitHub Actions build failures for Windows target.

chitoge commented 1 month ago

I verified that the build action succeeded with my own copy of the IDA 8.2 SDK: https://github.com/chitoge/binexport/actions/runs/11406555000/job/31740568206

chitoge commented 1 month ago

For various reasons I can't currently provide release packages. We'll also need to fix the Windows builds here on GitHub (protobuf linking against the wrong std lib) first.

Originally posted by @cblichmann in #50

Since BinDiff uses Abseil and Protobuf from BinExport, I think this PR will also fix the Windows build failure on BinDiff once it is merged.

cblichmann commented 1 month ago

Oh wow, I was not aware of that setting and was sort of disheartened to look into this, as I remember that mismatching runtimes are a pain to deal with usually.

Thanks! This will be merged after internal review, which should happen Monday/Tuesday (I'm OOO myself).

chitoge commented 1 month ago

Thanks for the quick update! I've also verified that this PR indeed fixed the BinDiff build on my fork.

It looks like the change has already been pulled onto main, so I'll close this PR.