google / blockly

The web-based visual programming editor.
https://developers.google.com/blockly/
Apache License 2.0
12.51k stars 3.72k forks source link

fix: Create CSS vars for SVG patterns. #8671

Open johnnesky opened 7 hours ago

johnnesky commented 7 hours ago

The basics

The details

Resolves

Fixes https://github.com/google/blockly/issues/8272

We'll need a related PR in blockly-samples that adapts the screenshot plugin to be aware of CSS vars.

Proposed Changes

Adds CSS variables scoped to the injection div referencing the SVG pattern ids so that CSS can use these consistent variable names instead of the random ids that were previously assigned to SVG attributes.

Reason for Changes

So that renderer CSS can customize and override how SVG patterns are used.

Test Coverage

I did not create any new tests, but all existing tests pass and I manually tested that the filters appear to be rendering correctly.

Documentation

N/A

Additional Information

N/A