search

google / caliban

Research workflows made easy, locally and in the Cloud.
https://caliban.readthedocs.io
Apache License 2.0
495 stars 67 forks source link

bugfix for https://github.com/google/caliban/issues/65 #67

Closed ajslone closed 4 years ago

ajslone commented 4 years ago

This addresses an error where we specify resource maxima for GKE clusters using quota information returned from the GCP compute API. The API can return a quota of zero for a given resource type, but requesting a limit of zero in the cluster creation API causes an error, so this change prevents setting a limit of zero for any resource.

codecov[bot] commented 4 years ago

Codecov Report

Merging #67 into master will increase coverage by 0.26%. The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
+ Coverage   51.41%   51.68%   +0.26%     
==========================================
  Files          30       30              
  Lines        2970     2972       +2     
==========================================
+ Hits         1527     1536       +9     
+ Misses       1443     1436       -7
Impacted Files Coverage Δ
caliban/platform/gke/util.py 72.90% <66.66%> (+2.51%) :arrow_up:
caliban/util/fs.py 89.62% <0.00%> (-0.95%) :arrow_down:
caliban/util/auth.py 76.19% <0.00%> (+9.52%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update af9dd99...1b5e274. Read the comment docs.