ajslone commented 4 years ago

This PR adds support for setting pubsub environment variables for use with UV's MLFlowPubsubReporter. These variables are configured via .calibanconfig.json.

codecov[bot] commented 4 years ago

Codecov Report

Merging #89 into master will increase coverage by 1.21%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
+ Coverage   54.31%   55.53%   +1.21%     
==========================================
  Files          31       31              
  Lines        3183     3180       -3     
==========================================
+ Hits         1729     1766      +37     
+ Misses       1454     1414      -40

Impacted Files	Coverage Δ
caliban/config/__init__.py	`100.00% <100.00%> (ø)`
caliban/util/metrics.py	`100.00% <100.00%> (ø)`
caliban/platform/gke/util.py	`98.13% <0.00%> (-1.87%)`	:arrow_down:
caliban/platform/cloud/types.py	`89.87% <0.00%> (-0.64%)`	:arrow_down:
caliban/history/cli.py	`13.40% <0.00%> (+0.06%)`	:arrow_up:
caliban/util/auth.py	`76.19% <0.00%> (+9.52%)`	:arrow_up:
caliban/resources/caliban_launcher.py	`100.00% <0.00%> (+66.15%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7e175c2...6428aa5. Read the comment docs.

sritchie commented 4 years ago

Hey @ajslone , feel free to merge if you think this looks good. Just re-ran the 3.8 tests and all is well.

google / caliban

added uv-mlflow env vars for pubsub reporter #89

Codecov Report