google / chatbase-node

Quickly integrate your Node.js chatbot with Chatbase Analytics
Apache License 2.0
77 stars 24 forks source link

Added custom_session_id handling #14

Closed frogermcs closed 6 years ago

frogermcs commented 6 years ago

Add the ability to define custom_session_id for the conversation with bot.

googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


frogermcs commented 6 years ago

I signed it!

frogermcs commented 6 years ago

For some reason my integration with chatbase logs sessions longer than 1h what looks impossible for voice assistant with scenario shorter than 3 messages. Adding custom_session_id could help with handling session length on chatbot side.

Mentioned integration was implemented in https://github.com/frogermcs/WaterLog-assistant-app (Google Assistant + Dialogflow).

googlebot commented 6 years ago

CLAs look good, thanks!

lorenzbaum commented 6 years ago

What's the problem? Just merge this feature, as we all need it!

frogermcs commented 6 years ago

And the second side of this improvement: https://github.com/actions-on-google/actions-on-google-nodejs/pull/90 :)

cristiancavalli commented 6 years ago

@frogermcs Thanks!

lorenzbaum commented 6 years ago

How about releasing it on npm?

writtmeyer commented 6 years ago

@cristiancavalli Please update the minor version of it and publish it to npm. It's and important addition we all would love to see :-)