search

google / ghc-source-gen

Library for generating Haskell source files and code fragments.
BSD 3-Clause "New" or "Revised" License
89 stars 29 forks source link

Support ghc-8.10. #69

Closed judah closed 4 years ago

judah commented 4 years ago

The biggest API change is that ghc-8.10 organizes its modules into a hierarchy, such as GHC.Hs.Expr instead of HsExpr. To work around that without adding even more CPP, I added some other-modules providing the new names for older GHC releases.

Fixes #65.

judah commented 4 years ago

I fixed the build failure; one of the wrapper modules didn't make it into the commit.

jinwoo commented 4 years ago

@judah I think this should be released to Hackage before other packages dependent on ghc-source-gen can support 8.10. Can you? Or do you want me to?

judah commented 4 years ago

@jinwoo sure, you can go ahead and release it. Do you have an account on Hackage? I can add you to the maintainers list.

jinwoo commented 4 years ago

Thank you, @judah . I just created an account, JinwooLee.

judah commented 4 years ago

OK, I've added you as a maintainer.

The stack upload command ought to do the job, but let me know if you get stuck.

jinwoo commented 4 years ago

Thank you, Judah!

jinwoo commented 4 years ago

When I do stack upload ., it fails with

You are not an authorized package uploader. Please contact the server trustees at hackage-trustees@haskell.org to request to be added to the Uploaders group.

I emailed hackage-trustees@haskell.org as instructed.

jinwoo commented 4 years ago

0.4.0.0 is now published.