search

google / ghc-source-gen

Library for generating Haskell source files and code fragments.
BSD 3-Clause "New" or "Revised" License
89 stars 29 forks source link

Add GHC 9 support to CI #87

Closed AriFordsham closed 3 years ago

AriFordsham commented 3 years ago

Based on https://github.com/mithrandi/ghc-source-gen/tree/ghc9, should be fully working.

google-cla[bot] commented 3 years ago

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

AriFordsham commented 3 years ago

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@mithrandi

google-cla[bot] commented 3 years ago

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

blackgnezdo commented 3 years ago

Very cool, thanks @AriFordsham for building up our CI. It reports some of the builds aren't quite healthy yet :)

mithrandi commented 3 years ago

@googlebot I consent.

AriFordsham commented 3 years ago

Now passing CI.

AriFordsham commented 3 years ago

@jinwoo @blackgnezdo can this be merged?

jinwoo commented 3 years ago

Sorry I don't think I have enough knowledge on this package to review this PR completely. As all the checks passed, this is probably fine. @blackgnezdo , @judah if you guys think this is good, I'm fine with merging. If I don't hear any responses in 2-3 days, I'll merge this.

AriFordsham commented 3 years ago

77

blackgnezdo commented 3 years ago

@AriFordsham would you mind rewriting your commits so that they are all squashed together? I doubt there's much value in preserving this part of history. I also don't want to squash your and @mithrandi's commit together which is the only other alternative in the UI

blackgnezdo commented 3 years ago

@mithrandi I believe your two commits would also benefit from either getting squashed or having a more detailed description.

AriFordsham commented 3 years ago

All done.

mithrandi commented 3 years ago

I think I need @AriFordsham to squash them for me (no write access to this branch).

AriFordsham commented 3 years ago

@mithrandi If you squash them on your branch at https://github.com/mithrandi/ghc-source-gen/tree/ghc9 I can pull them in. I wouldn't want you to lose the attribution.

mithrandi commented 3 years ago

Done!

AriFordsham commented 3 years ago

Ready to roll.

blackgnezdo commented 3 years ago

Thank you @mithrandi and @AriFordsham! This was an example of awesome open source collaboration!