Closed brandon-leapyear closed 3 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
and we'll verify it.
ℹ️ Googlers: Go here for more info.
:sparkles: This is an old work account. Please reference @brandonchinn178 for all future communication :sparkles:
@googlebot I signed it!
Thanks @brandon-leapyear, this is an awesome cleanup!
:sparkles: This is an old work account. Please reference @brandonchinn178 for all future communication :sparkles:
This allows people to specify
ghc-source-gen
as an extra-dep via git commit:For example, it's useful now, to be able to use the
HEAD
ofghc-source-gen
without waiting for a Hackage release. But this only works if the repo has.cabal
committed. (more info: https://www.fpcomplete.com/blog/storing-generated-cabal-files/)Also added a check in CI to ensure that the cabal file has been updated. I also simplified the CI config with Circle CI's new parameterized jobs syntax, which also fixes some bugs (e.g. the
build-ghc-9.0
job specified the wrong cache keys when restoring, so it was previously always a cache miss)