search

google / ghc-source-gen

Library for generating Haskell source files and code fragments.
BSD 3-Clause "New" or "Revised" License
89 stars 29 forks source link

Add support for GHC 9.2 #92

Closed brandon-leapyear closed 2 years ago

brandon-leapyear commented 2 years ago

:sparkles: This is an old work account. Please reference @brandonchinn178 for all future communication :sparkles:

blackgnezdo commented 2 years ago

I'm confused why CI is not working. Any ideas?

brandon-leapyear commented 2 years ago

:sparkles: This is an old work account. Please reference @brandonchinn178 for all future communication :sparkles:

CI didnt run because I prefixed the commit with "[ci skip]". But I'm still working on this anyway

brandon-leapyear commented 2 years ago

:sparkles: This is an old work account. Please reference @brandonchinn178 for all future communication :sparkles:

Ok made a bit of headway. If anyone else has time, feel free to take this over. This is a pretty tough codebase to update :)

brandon-leapyear commented 2 years ago

:sparkles: This is an old work account. Please reference @brandonchinn178 for all future communication :sparkles:

Got it to compile locally! Not sure if everything is the "correct" way to fix it, but I got it working. Feel free to suggest changes

blackgnezdo commented 2 years ago

I notice we lost ghc-9.0 from our CI, do you believe it's not useful? Considering we still have 9.0-specific ifdef's, it appears to make sense to check that version too.

brandon-leapyear commented 2 years ago

:sparkles: This is an old work account. Please reference @brandonchinn178 for all future communication :sparkles:

ah you're right. just re-added it

blackgnezdo commented 2 years ago

@jinwoo maybe you have write access to merge this? I don't...

jinwoo commented 2 years ago

Thanks!