Closed Mivekk closed 2 months ago
I'm not sure how I should modify cleaner test cases unfortunately
You can extend any of the cleanup_*_unittest.cc
, for instance, here
https://github.com/google/glog/blob/ac12a9e79440a2a89cc1c5617bb8f6db02035182/src/cleanup_immediately_unittest.cc#L62-L64
by additionally logging at the missing severities.
Please note that the unit tests need to be updated either way because these are failing now with your changes.
Updated unit test and all checks should pass now hopefully
Unfortunately, the cleanup tests are still failing.
Fixed an issue different way
The unit tests are still failing though.
Closing as abandoned. Please let me know if you want to continue working on this PR.
Previously when executing following code LogCleaner would only delete overdue Error log files:
And if we changed the order to for example:
LogCleaner would only delete overdue Info log files and overdue Error and Warning files were ignored. To include all severities during LogCleaner's sweep I tested filepath for all severities in a IsLogFromCurrentProject function.