google / glog

C++ implementation of the Google logging module
http://google.github.io/glog/
BSD 3-Clause "New" or "Revised" License
7.01k stars 2.05k forks source link

Update README to Bzlmod usage #1099

Closed Vertexwahn closed 3 months ago

Vertexwahn commented 4 months ago

Update README to Bzlmod usage

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.04%. Comparing base (45f99f5) to head (3d61ef6).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1099 +/- ## ========================================== + Coverage 63.57% 64.04% +0.46% ========================================== Files 20 20 Lines 2578 2578 Branches 894 891 -3 ========================================== + Hits 1639 1651 +12 + Misses 671 662 -9 + Partials 268 265 -3 ``` [see 2 files with indirect coverage changes](https://app.codecov.io/gh/google/glog/pull/1099/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=google)
Vertexwahn commented 3 months ago

@sergiud I forgot to update the documentation - this PR updates the docs according to the merged change https://github.com/google/glog/pull/1097

sergiud commented 3 months ago

Thanks! I intend to merge your changes after #1101, which heavily reworks the documentation. Sorry for the inconvenience.

sergiud commented 3 months ago

@Vertexwahn You can go ahead and apply your changes on top of the mkdocs branch.

Vertexwahn commented 3 months ago

@sergiud Rebased my change

sergiud commented 3 months ago

Thank you!