Open AustinSchuh opened 1 month ago
https://github.com/google/glog/pull/1074 refactored some of the code to enable the failure function to throw. This made it so when the LogMessageFatal class was used, the error ended up being printed differently.
Before: LOG_AT_LEVEL(google::LogSeverity::FATAL) << "Crash: Hello world!"; ->
F20240621 18:12:44.710584 139620827212672 log_demo.cc:16] Crash: Hello world! Check failure stack trace: @ 0x559e2704711a @ 0x7efc01fac24a @ 0x7efc01fac305 @ 0x559e27046dd5 Aborted
LOG(FATAL) << "Crash: Hello world!"; ->
F20240621 18:13:05.760556 140518290856832 log_demo.cc:16] Crash: Hello world! @ 0x55cdc2475130 @ 0x7fccf6fb324a @ 0x7fccf6fb3305 @ 0x55cdc2474df5 Aborted
With this patch, they both produce the same output.
Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
50.00000%
1 line
Project coverage is 63.65%. Comparing base (45f99f5) to head (039298a).
45f99f5
039298a
https://github.com/google/glog/pull/1074 refactored some of the code to enable the failure function to throw. This made it so when the LogMessageFatal class was used, the error ended up being printed differently.
Before: LOG_AT_LEVEL(google::LogSeverity::FATAL) << "Crash: Hello world!"; ->
F20240621 18:12:44.710584 139620827212672 log_demo.cc:16] Crash: Hello world! Check failure stack trace: @ 0x559e2704711a @ 0x7efc01fac24a @ 0x7efc01fac305 @ 0x559e27046dd5 Aborted
LOG(FATAL) << "Crash: Hello world!"; ->
F20240621 18:13:05.760556 140518290856832 log_demo.cc:16] Crash: Hello world! @ 0x55cdc2475130 @ 0x7fccf6fb324a @ 0x7fccf6fb3305 @ 0x55cdc2474df5 Aborted
With this patch, they both produce the same output.