RELNOTES=io: Changed ByteSink and CharSink to no longer call flush() in some cases before close(). This is a no-op for well-behaved streams, which internally flush their data as part of closing. However, we have discovered some stream implementations that have overridden close() to do nothing, including not to flush some buffered data. If this change causes problems, the simplest fix is usually to change the close() override to at least call flush().
Roll forward cl/688155711, which was rolled back in cl/688191691.
The broken
Writerimplementation that saw trouble after the previous attempt has been fixed.Remove a couple more obsolete workarounds for
FilterOutputStreamtrouble.See https://github.com/google/guava/issues/1330.
I have the others taken care of in cl/687314611.
RELNOTES=
io: ChangedByteSinkandCharSinkto no longer callflush()in some cases beforeclose(). This is a no-op for well-behaved streams, which internally flush their data as part of closing. However, we have discovered some stream implementations that have overriddenclose()to do nothing, including not to flush some buffered data. If this change causes problems, the simplest fix is usually to change theclose()override to at least callflush().