search

google / guava

Google core libraries for Java
Apache License 2.0
50.24k stars 10.91k forks source link

Javadoc shortcuts don't preserve anchor/fragment #7481

Closed cpovirk closed 4 weeks ago

cpovirk commented 1 month ago

I continue to be very happy that we offer the ability to type "guava.dev/futures" into your browser and end up at https://guava.dev/releases/snapshot-jre/api/docs/com/google/common/util/concurrent/Futures.html. The main use case is for people who are tying that into a browser, so that works fine.

However, it would also be cool if links (like in Markdown documentation) could use https://guava.dev/Futures#immediateVoidFuture() instead of https://guava.dev/releases/snapshot-jre/api/docs/com/google/common/util/concurrent/Futures.html#immediateVoidFuture(). However, that doesn't work: The # part gets lost as part of the redirect.

I think that we use some kind of plugin-ish thing for our redirects. We could see if it offers a way to support this, or we could roll our own JavaScript that does a better job (likely with <meta> and perhaps even <a href=...> fallback, as I assume that our existing solution uses).

(I think I have noticed this before today but not previously filed an issue.)

cpovirk commented 4 weeks ago

Fixed in https://github.com/google/guava/pull/7483 by @chaoren .