google / gvisor

Application Kernel for Containers
https://gvisor.dev
Apache License 2.0
15.88k stars 1.3k forks source link

gVisor VDSO may span multiple maps entries #157

Open amscanne opened 5 years ago

amscanne commented 5 years ago

The VDSO mapped by the sentry has a writable segment, so we have more than one maps entry.

Linux always has a single VDSO entry.

We currently avoid advertising the VDSO in maps to avoid breaking userspace programs that expect a single VDSO entry.

github-actions[bot] commented 1 year ago

A friendly reminder that this issue had no activity for 120 days.

github-actions[bot] commented 10 months ago

A friendly reminder that this issue had no activity for 120 days.

github-actions[bot] commented 7 months ago

This issue has been closed due to lack of activity.

github-actions[bot] commented 7 months ago

There are TODOs still referencing this issue:

  1. pkg/sentry/loader/vdso.go:224: Don't advertise the VDSO, as

Search TODO

prattmic commented 2 months ago

FYI, with the addition of getrandom to the upstream vDSO, Linux's also spans multiple pages, so multiple pages is presumably no longer a (potential) problem. Though I'm not sure if there are multiple [vdso] entries in /proc/PID/maps, or if there is a single multi-page mapping.

zx2c4 commented 2 months ago

Single multipage mapping.