Closed christofferqa closed 5 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
and we'll verify it.
ℹ️ Googlers: Go here for more info.
LGTM, thanks!
Stop unsubscribe
On Thu, Oct 3, 2019, 6:11 AM Christoffer Quist Adamsen < notifications@github.com> wrote:
This reduces the dex size of the app from 8.096.972 to 6.760.920 bytes.
You can view, comment on, or merge this pull request online at:
https://github.com/google/iosched/pull/328 https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgoogle%2Fiosched%2Fpull%2F328&data=02%7C01%7C%7C938971e8fa1d4eed118d08d747f274ec%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637056978968452736&sdata=CP73djeX5iEgKaXMYqv1oOiiU14TV3KULntZ8mi63I8%3D&reserved=0 Commit Summary
- Enable more aggressive code optimizations
File Changes
- M gradle.properties https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgoogle%2Fiosched%2Fpull%2F328%2Ffiles%23diff-0&data=02%7C01%7C%7C938971e8fa1d4eed118d08d747f274ec%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637056978968462973&sdata=pxxIFlgkVHI6xXzbLk6WfK9bxjx3e8xQrOm1FXJj5t8%3D&reserved=0 (3)
- M mobile/build.gradle https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgoogle%2Fiosched%2Fpull%2F328%2Ffiles%23diff-1&data=02%7C01%7C%7C938971e8fa1d4eed118d08d747f274ec%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637056978968472750&sdata=Y8maJP3HoaUPUoAQI%2FN689N2Nqq%2BhIGtUDc%2F5cZh1iQ%3D&reserved=0 (2)
- M shared/consumer-proguard-rules.pro https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgoogle%2Fiosched%2Fpull%2F328%2Ffiles%23diff-2&data=02%7C01%7C%7C938971e8fa1d4eed118d08d747f274ec%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637056978968472750&sdata=rLTCUTj5x8q9FUxBBPa6AP1%2BFkmNbu9mjNHKYNwIwck%3D&reserved=0 (4)
Patch Links:
- https://github.com/google/iosched/pull/328.patch https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgoogle%2Fiosched%2Fpull%2F328.patch&data=02%7C01%7C%7C938971e8fa1d4eed118d08d747f274ec%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637056978968482755&sdata=ET5fbNfwfGV7pEqQaGsjHUTOjZaNYuS%2B%2FEHIabKjcu0%3D&reserved=0
- https://github.com/google/iosched/pull/328.diff https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgoogle%2Fiosched%2Fpull%2F328.diff&data=02%7C01%7C%7C938971e8fa1d4eed118d08d747f274ec%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637056978968482755&sdata=7cOsTo%2BZwT%2FdKibJCsny64SpbGGQOqdp3mfqD8wmIk0%3D&reserved=0
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgoogle%2Fiosched%2Fpull%2F328%3Femail_source%3Dnotifications%26email_token%3DAMCHA23QCI72GNB252WLUBTQMXHOPA5CNFSM4I5BUQT2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HPL5KZQ&data=02%7C01%7C%7C938971e8fa1d4eed118d08d747f274ec%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637056978968492765&sdata=JOGj17M2qSreOkdXktk7c8tFobgtGMitcVzl%2FzVglk8%3D&reserved=0, or mute the thread https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAMCHA26KRTDCKUIYULU7H6DQMXHOPANCNFSM4I5BUQTQ&data=02%7C01%7C%7C938971e8fa1d4eed118d08d747f274ec%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637056978968492765&sdata=eB6FAlRrCmWj5a%2F7OIp1MyK1nIl81%2F9m3lFcpDHoXyw%3D&reserved=0 .
Unsubscribe
This reduces the dex size of the app from 8.096.972 to 6.760.920 bytes.