search

google / jaxopt

Hardware accelerated, batchable and differentiable optimizers in JAX.
https://jaxopt.github.io
Apache License 2.0
936 stars 66 forks source link

added the computed initialization of the jac approx in Broyden #529

Open zaccharieramzi opened 1 year ago

zaccharieramzi commented 1 year ago

WIP: need to run the existing tests and add the previously failing test written by @vroulet in a previous PR

In order to implement this change, I had to change the dtype of gamma which is now a pytree rather than a scalar, since it can be different for each leaf of the parameters.

zaccharieramzi commented 12 months ago

So actually the failure that @vroulet was showcasing here is actually already a test in the broyden test suite.

Everything is green now (with simpler settings), so this is ready for review.