search

google / jetpack-camera-app

Apache License 2.0
152 stars 29 forks source link

settings for video time limit #255

Closed Kimblebee closed 2 months ago

Kimblebee commented 3 months ago

settings for video time limit. based on top of #231 Implement time limit to recordings

Kimblebee commented 2 months ago

This looks great. Thanks! A few thoughts for next steps:

  1. Once Fix tests which don't specify explicit URI #265 is merged, you should add a test for video recordings.
  2. We need some UI affordances. We need something to tell the user that a duration limit is currently enabled before they start the recording, and also some kind of UI that tells the user how much time they have remaining before reaching the limit. These can be in follow-up PRs.

Thanks! I'll file some bugs to track these