search

google / jsinterop-generator

Generates Java annotated with JsInterop from JavaScript extern sources
Apache License 2.0
75 stars 24 forks source link

Use google/bazel-common #7

Closed tbroyer closed 5 years ago

tbroyer commented 6 years ago

This is in preparation for doing the same in elemental2, for sharing dependency declarations (elemental2 would also use pom_file and possibly javadoc_library rules)

realityforge commented 6 years ago

This looks neat. I was just going to try to do the same with elemental2 (See https://github.com/google/elemental2/pull/48) but it seems you may be further along. I am largely unfamiliar with bazel but can try to apply the same logic in elemental2 unless you have started down that path.

Thoughts?

realityforge commented 6 years ago

@jDramaix What is the status of this? Is there anything that needs to be done to get this merged? And then consequently get https://github.com/google/elemental2/pull/50 merged?

tbroyer commented 6 years ago

Fwiw, the javadoc_library is not ready yet (for Elemental 2).

Also this now needs to be updated to a newer bazel_common with updated dependencies.

jDramaix commented 5 years ago

I'm closing this PR as our way to define our workspace is now different