search

google / log4jscanner

A log4j vulnerability filesystem scanner and Go package for analyzing JAR files.
Apache License 2.0
1.56k stars 121 forks source link

feat/backup #64

Open karchx opened 2 years ago

karchx commented 2 years ago

JARs backup at the time of running the inspection on the jar files, either a scan or with the --rewrite command, for example

log4scanner -b -w ./jar/testdata

the copy of the JARs is saved in 

backup/*.jar

This may solve the issues:

Any improvement will be a pleasure to carry it out

karchx commented 2 years ago

@ericchiang Done, Any improvement I would be very grateful if you mention it and so I work on it, but I think it's pretty good.

ericchiang commented 2 years ago

Thanks! mostly just a comment about creating a new directory vs not

karchx commented 2 years ago

Done

ericchiang commented 2 years ago

also, can you please squash your commits?

karchx commented 2 years ago

@ericchiang I was squashing commits and the PR seemed to be closed

ericchiang commented 2 years ago

It looks like you've got some conflicts? If you need to open a new PR feel free, or I can pull in the changes myself.

karchx commented 2 years ago

If it's not too much of a problem, I'll leave it to you.