Open lampajr opened 9 months ago
Nit: you might want to update this comment: https://github.com/google/ml-metadata/pull/189/files#diff-0c3fe2859affc74bb85407ef9414003f0f77e4d5a0db30d3f67e57b03c5979ebR344
Edit: this error message must also be updated: https://github.com/google/ml-metadata/pull/189/files#diff-0c3fe2859affc74bb85407ef9414003f0f77e4d5a0db30d3f67e57b03c5979ebR340
Nit: you might want to update this comment: https://github.com/google/ml-metadata/pull/189/files#diff-0c3fe2859affc74bb85407ef9414003f0f77e4d5a0db30d3f67e57b03c5979ebR344
Edit: this error message must also be updated: https://github.com/google/ml-metadata/pull/189/files#diff-0c3fe2859affc74bb85407ef9414003f0f77e4d5a0db30d3f67e57b03c5979ebR340
Nice catch, updated!
Hey @XinranTang, is there any chance to get this in?
Hey @XinranTang, is there any chance to get this in?
Any news?
While using
ml-metadata
I noticed that there is no way to startup the server usingsqlite
configuration through flags, the only way I found (as stated by the documentation) was to use theconfig_file
file option pointing to apb
file like:With this pull request I am proposing to introduce the possibility to startup the grpc server with
sqlite
config using cmdline flags, similarly to what is currently supported formysql
andpostgresql
.Given this, the previous configuration could be replaced by cmdline flags as follow:
Technical addition
This PR proposes to add a:
metadata_source_config_type
namedsqlite
metadata_source_config_type==sqlite
:--sqlite_config_filename_uri
: required, specifies the sqlite db uri.--sqlite_config_connection_mode
: optional, specifies the sqlite connection mode. Default isREADWRITE_OPENCREATE