Open philburk opened 5 months ago
Make sure destructors do not call any virtual functions. They were reviewed on 2024-06-08. Only empty or default destructors found.
Use "= default" in: src/common/FixedBlockAdapter.h src/common/MonotonicCounter.h src/opensles/AudioInputStreamOpenSLES.cpp
Move "= default" from .cpp to .h: src/flowgraph/MultiToManyConverter.cpp src/flowgraph/ChannelCountConverter.cpp
Maybe add destructor to: src/flowgraph/Limiter.h src/flowgraph/SinkI16.h src/flowgraph/SinkI24.h src/flowgraph/SourceI24.h src/opensles/AudioStreamBuffered.h src/common/DataConversionFlowGraph.h src/common/SourceFloatCaller.h src/common/SourceI16Caller.h src/common/SourceI32Caller.h
Review, why override? src/flowgraph/SinkFloat.h src/flowgraph/SinkI32.h src/flowgraph/SourceI8_24.h
Make sure destructors do not call any virtual functions. They were reviewed on 2024-06-08. Only empty or default destructors found.
Use "= default" in: src/common/FixedBlockAdapter.h src/common/MonotonicCounter.h src/opensles/AudioInputStreamOpenSLES.cpp
Move "= default" from .cpp to .h: src/flowgraph/MultiToManyConverter.cpp src/flowgraph/ChannelCountConverter.cpp
Maybe add destructor to: src/flowgraph/Limiter.h src/flowgraph/SinkI16.h src/flowgraph/SinkI24.h src/flowgraph/SourceI24.h src/opensles/AudioStreamBuffered.h src/common/DataConversionFlowGraph.h src/common/SourceFloatCaller.h src/common/SourceI16Caller.h src/common/SourceI32Caller.h
Review, why override? src/flowgraph/SinkFloat.h src/flowgraph/SinkI32.h src/flowgraph/SourceI8_24.h