Fix PL/pgSQL encoding and decoding

google / open-location-code

Open Location Code is a library to generate short codes, called "plus codes", that can be used as digital addresses where street addresses don't exist.

https://plus.codes

Apache License 2.0

4.06k stars 471 forks source link

Fix PL/pgSQL encoding and decoding #478

Closed markborkum closed 2 years ago

markborkum commented 2 years ago

Fixes #467

This PR rewrites the "pluscode_encode" function by porting the Python implementation to PL/pgSQL. The "pluscode_computeLatitudePrecision" function is also ported to mirror the Python implementation.

This PR fixes a bug in the "pluscode_decode" function, where the row and column place values were not being initialized correctly.

markborkum commented 2 years ago

CLA signed. Do we need a new PR so that the check passes?

bilst commented 2 years ago

Thanks for the fix!

Hmm I reran it but CLA check still isn't passing, can you take a look at suggestions of what to double-check in https://github.com/google/open-location-code/pull/478/checks?check_run_id=4873508539? ("Help! I've signed the CLA, but it's still showing me as unsigned.")