search

google / osv-scanner

Vulnerability scanner written in Go which uses the data provided by https://osv.dev
https://google.github.io/osv-scanner/
Apache License 2.0
6.28k stars 363 forks source link

refactor: use `.gohtml` extension rather than suffixing templates with `_template` #1388

Closed G-Rath closed 2 weeks ago

G-Rath commented 3 weeks ago

This means that IDEs like Goland automatically infer these files as Go templates, while still making it clear what files are templates vs "native" files

codecov-commenter commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.74%. Comparing base (9fcf53f) to head (1cbf39c).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1388 +/- ## ========================================== - Coverage 68.75% 68.74% -0.02% ========================================== Files 184 184 Lines 17714 17714 ========================================== - Hits 12180 12177 -3 - Misses 4875 4877 +2 - Partials 659 660 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

hogo6002 commented 2 weeks ago

Thanks! I'll close this PR for now since the original files have been modified (lots of conflicts). I'll make the changes in a follow-up PR where I'll also refactor the code a bit.