google / play-services-plugins

Plugins to help with using Google Play services SDK.
https://developers.google.com/android/guides/overview
Apache License 2.0
471 stars 138 forks source link

Add google-services.json as a task input, to fix up-to-date checks #240

Closed mrichards closed 2 years ago

mrichards commented 2 years ago

google-services.json was not previously treated as a task input, so changes to that file would not cause the task's UP-TO-DATE check to return false. As a result, the generated values.xml file is never updated unless clean is run after editing the json file, which seems buggy and has customer problems.

See this issue in the firebase-android-sdk repo, as an example.

brunobowden commented 2 years ago

@mrichards - please excuse the "+1" but thanks for following through on fixing this