search

google / pprof

pprof is a tool for visualization and analysis of profiling data
Apache License 2.0
8.03k stars 608 forks source link

Remove special coloring for self region in new flame graph view. #782

Closed ghemawat closed 1 year ago

ghemawat commented 1 year ago

Previously, the self cost part of a flame graph box was shown with a tweaked color.

[<-- self --><-- rest of the cost -->]
             [child 1][child2][child3]

However this added clutter and was too subtle (I asked a couple of colleagues and they hadn't noticed it).

This change removes this coloring. The self cost is still available in the tooltip for each box and is also visible as the area to the left of the first child.

aalexand commented 1 year ago

@ghemawat Could you approve https://github.com/google/pprof/pull/780? This will fix the stuck CI in this and other PRs.

ghemawat commented 1 year ago

Approved #780. Thanks.

codecov-commenter commented 1 year ago

Codecov Report

Merging #782 (4adcd79) into main (b1315fa) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 4adcd79 differs from pull request most recent head 64c6d71. Consider uploading reports for the commit 64c6d71 to get more accurate results

@@           Coverage Diff           @@
##             main     #782   +/-   ##
=======================================
  Coverage   66.99%   66.99%           
=======================================
  Files          45       45           
  Lines        9861     9861           
=======================================
  Hits         6606     6606           
  Misses       2795     2795           
  Partials      460      460