google / pprof

pprof is a tool for visualization and analysis of profiling data
Apache License 2.0
8.03k stars 608 forks source link

Introduce first test for browser-side behavior. #798

Closed ghemawat closed 1 year ago

ghemawat commented 1 year ago

Added a test that uses chromedp to drive web page interactions and check the resulting display.

Caveat: just adding a single test initially (it checks sorting of the "Top" view table). Other tests will be added later.

Caveat: coverage of browser Javascript is not gathered, so we won't be able to rely on coverage to measure quality/changes in Javascript testing.

codecov-commenter commented 1 year ago

Codecov Report

Merging #798 (2b14af0) into main (2861d24) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #798   +/-   ##
=======================================
  Coverage   66.99%   66.99%           
=======================================
  Files          45       45           
  Lines        9861     9861           
=======================================
  Hits         6606     6606           
  Misses       2795     2795           
  Partials      460      460           
aalexand commented 1 year ago

Will merge once tests complete.

ghemawat commented 1 year ago

I sync-ed with other changes, dropped the unnecessary action to setup chrome (it is already available by default in github runners), and dropped the "-v" from the "go test" invocation.

This should now be fine to merge.

Louis-Ye commented 1 year ago

Marking #791 as fixed