search

google / pprof

pprof is a tool for visualization and analysis of profiling data
Apache License 2.0
8.03k stars 608 forks source link

Change the main binary override feature to override all consecutive initial mappings #889

Closed ykadowak closed 3 months ago

ykadowak commented 3 months ago

Closes https://github.com/google/pprof/issues/885.

As described in the issue, in our use case, the mappings of the main binary consist of multiple lines. Although pprof offers a function to override the name of the main binary by passing a new one, it only overrides the first mapping.

This PR changes the behavior to override all consecutive initial mappings if their main binary names are the same.

I don't understand pprof enough to know what it means when there are multiple lines of mapping for the main binary. So if there's a better way to handle this, please let me know.

At the very least, the tests are passing, and I believe this PR does not change the existing behavior.

google-cla[bot] commented 3 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.