google / project-gameface

Apache License 2.0
588 stars 84 forks source link

customtkinter.CTkSwitch initialization missing fg_color argument #7

Open githubpsyche opened 1 year ago

githubpsyche commented 1 year ago

https://github.com/google/project-gameface/blob/8faf5cfbf7127b9f9995c49cec1064e338624c58/src/gui/frames/frame_cam_preview.py#L68

Returns this error when I follow the Python app setup instructions.

'fg_color'
  File "C:\Users\gunnj\project-gameface\src\gui\frames\frame_cam_preview.py", line 68, in __init__
    self.toggle_switch = customtkinter.CTkSwitch(
  File "C:\Users\gunnj\project-gameface\src\gui\main_gui.py", line 62, in __init__
    self.frame_preview = frames.FrameCamPreview(self.tk_root,
  File "C:\Users\gunnj\project-gameface\run_app.py", line 35, in __init__
    super().__init__(tk_root)
  File "C:\Users\gunnj\project-gameface\run_app.py", line 66, in <module>
    main_app = MainApp(tk_root)
KeyError: 'fg_color'

Application fails to load as long as the error is maintained. Adding a fg_color argument and specifying an arbitrary color eliminates the error and allows the Application to run. (I am, however, still experiencing the issue described in #5 concerning cursor movement.)

galaktyk commented 1 year ago

Lowering customtkinter from version 5.1.3 to version 5.1.2 fixes the problem.👍

Richmond-AT commented 1 year ago

Lowering customtkinter from version 5.1.3 to version 5.1.2 fixes the problem.👍

How (for a noob) do I "lower customtkinter from version 5.1.3 to version 5.1.2"? Thank you!

githubpsyche commented 1 year ago

Instead of downloading the program through the release section, you'd need to follow the Python application setup instructions. However, after the pip install -r requirements.txt step, you'd downgrade customtkinter via an additional command pip install customtinkier==5.1.2

willwade commented 1 year ago

NB: Upgrade customtkinter 5.2.0 and sort this stupid typo: https://github.com/google/project-gameface/blob/67f01207f924bc00f7991d53d4c6d0bb4dcd22fd/assets/themes/google_theme.json#L51 thats the fix for this