Initialize socket_factory_ to nullptr

google / quiche

BSD 3-Clause "New" or "Revised" License

659 stars 132 forks source link

Initialize socket_factory_ to nullptr #57

Closed djmitche closed 1 year ago

djmitche commented 1 year ago

This fixes a segfault when trying to use --connect-proxy-destinations, replacing it with a DCHECK error.

I wasn't able to figure out how to actually get this functionality operating, in the short amount of time I had to try. But this at least fixes the segfault.

DavidSchinazi commented 1 year ago

Let's discuss internally about making changes to the source of truth

djmitche commented 1 year ago

(fixed internally)