search

google / samba-documents-provider

Access network file shares directly from the Android Downloads/Files app
GNU General Public License v3.0
638 stars 125 forks source link

Store passwords encrypted #42

Closed Maxxee closed 6 years ago

Maxxee commented 6 years ago

Have a look in ServerCachePref.xml and be shocked. All passwords are stored there in plain text. Professional coding...not by Google.

ttanxu commented 6 years ago

Fixed in pull #32.

Please note that full disk encryption is enabled for all N devices and there are other security measures in Android system. It's in particular suspicious that you have access to this private file. Possibly you've rooted your phone, and with root access granted to any user, we can never be sure what apps may do to these credentials. Please note it's also your responsibility to protect your own credentials.