Closed onorua closed 8 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!
) and we'll verify. Thanks.
I signed it!
CLAs look good, thanks!
I suggest to use FROM debian:jessie rather than FROM ubuntu:* in this dockerfile, to be far away from any Canonical's IP Policy speculations...
By the way, Google CLAs also signed!
If that the reason to don't merge - I'll update the base image. Many projects use Ubuntu as base image which makes it better candidate to prevent downloading of the underlying layers.
If seesaw run in docker, It may be would better add some command and explanation. For example, It may use like "$ docker run -d seesaw". @onorua Do you have some idea?
$ docker run -d seesaw can be done after Dockerfile accepted and official image on Hub published
I do not run seesaw in the docker, I do build of the packages without necessary installing anything on your host. That is why I call it "hack" the same way as kubernetes has it, if you want to hack around, you need to be able to build it. But I can work on running the seesaw inside the docker as well, if there is a need. But this most probably be another pull request.
This should simplify adoption by the community, and may save couple of hours for new users who would like to just try the tool without additional efforts.