google / site-kit-wp

Site Kit is a one-stop solution for WordPress users to use everything Google has to offer to make them successful on the web.
https://sitekit.withgoogle.com
Apache License 2.0
1.25k stars 292 forks source link

Finalize TwG tag placement implementation based on updated script API #5535

Closed felixarntz closed 2 years ago

felixarntz commented 2 years ago

The TwG JS snippet was originally configured in #5450, however the underlying TwG JS library is being updated to satisfy the additional requirements and options that need to be available for the TwG launch (for which Site Kit is already receiving the necessary options, e.g. the color customization).

Once the JS library is updated, we need to make sure to pass the configuration parameters to it correctly based on the TwG module settings in Site Kit.

This issue is effectively blocked until the updated version of the TwG JS snippet has been launched.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

In includes/Modules/Thank_With_Google/Web_Tag.php:

In includes/Modules/Thank_With_Google.php, update the register_tag method:

Test Coverage

QA Brief

Changelog entry

eugene-manuilov commented 2 years ago

IB ✔️

mohitwp commented 2 years ago

QA Update ✅

Overlay type : ![image](https://user-images.githubusercontent.com/94359491/185040664-fa062561-df1e-4d50-ad54-247594d40957.png) ![image](https://user-images.githubusercontent.com/94359491/185040688-0df79fc8-8453-43a3-acfa-f777a7f51ac3.png) TWG Script: ![image](https://user-images.githubusercontent.com/94359491/185040807-636ad713-ff43-45aa-831a-651cf7132fb7.png) Prominence : High ![image](https://user-images.githubusercontent.com/94359491/185040895-592fef43-df71-4c4e-b1f8-a35048f8bdad.png) ![image](https://user-images.githubusercontent.com/94359491/185040935-36b3d8f8-6b42-464f-ac55-1ab5065b7ff1.png) Type : Fixed ![image](https://user-images.githubusercontent.com/94359491/185040992-4f33759b-cbc6-40f5-a113-d9c52fc5a0a0.png) ![image](https://user-images.githubusercontent.com/94359491/185041046-6f093978-f06e-42fc-9e2f-405ecc9f3cf6.png)