Open jimmymadon opened 2 months ago
Moving this to the backlog until #8976, which is marked as blocking this issue, is completed. That way we can mirror the approach used in #8976 for other migrations/refactoring.
AC ✔️
IB ✔️
@aaemnnosttv @sigal-teller
When refactoring this issue, I noticed that when we click on the main CTA, it takes us to an external link in a new window but this does not dismiss the notification. Sometimes, this behaviour is actually good because it allows the user to visit the link again if they accidentally close the new window. So we should either:
OR
@jimmymadon I was thinking about the first option as well. I think it's good idea to keep the CTA because if the user didn't complete customization or lost the page, it will be easier for him to re-visit the link and dismiss it at his convinience. I would replace the "Maybe later" with "got it", this is what we're using in otehr features.
Feature Description
This is the first issue that refactors the newly implement "subtle notifications" in the plugin as part of Phase 1 of the Banner Notifications Refactoring epic. It should refactor the
RRMSetupSuccessSubtleNotification
so that it uses the new datastore infrastructure to register and queue the notification. It should also incorporate the newly introducedSubtleNotification
component as a new "layout"Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
RRMSetupSuccessSubtleNotification
component should be refactored so that it is registered and rendered (queued) using the newcore/notifications
datastore.<SubtleNotifications>
) but only via the genericgetQueuedNotifications
selector.SubtleNotification
component and refactor this reusable component as a new "layout" within the new notifications framework.Implementation Brief
assets/js/modules/reader-revenue-manager/components/dashboard/RRMSetupSuccessSubtleNotification.js
assets/js/components/notifications/GatheringDataNotification.js
for the exampleSubtleNotification
componentid
andNotification
Notification
component passed as the propSubtleNotification
to create a new layoutassets/js/googlesitekit/notifications/components/layout/SubtleNotification.js
assets/js/googlesitekit/notifications/register-defaults.js
checkRequirements
transfer the existing checks fromassets/js/components/notifications/SubtleNotifications.js
andRRMSetupSuccessSubtleNotification
component itself10
from the last added notification (not including error ones, which start from150
).NOTIFICATION_AREAS.BANNERS_BELOW_NAV
forareaSlug
RRMSetupSuccessSubtleNotification
from theassets/js/components/notifications/SubtleNotifications.js
Test Coverage
assets/js/modules/reader-revenue-manager/components/dashboard/RRMSetupSuccessSubtleNotification.stories.js
QA Brief
/wp-admin/admin.php?page=googlesitekit-dashboard¬ification=authentication_success&slug=reader-revenue-manager
Changelog entry